Skip to content

chore(iast): removing redundant operations #13410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 19, 2025
Merged

chore(iast): removing redundant operations #13410

merged 7 commits into from
May 19, 2025

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented May 14, 2025 •
edited
Loading

Removing redundant operations:

  • call start_iast_context with span to skip a core.get_span() call
  • remove redundant calls to asm_config.is_iast_request_enabled and asm_config._iast_enabled
  • remove @WeakHash.wrap because it's a redundant call to asm_config.is_iast_request_enabled

This PR is part of #13347

APPSEC-57161

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels May 14, 2025
@avara1986 avara1986 changed the title chore(iast): remove redundant operations chore(iast): removing redundant operations May 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

ddtrace/appsec/_deduplications.py                                       @DataDog/asm-python
ddtrace/appsec/_iast/_iast_request_context_base.py                      @DataDog/asm-python
ddtrace/appsec/_iast/constants.py                                       @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/_base.py                               @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/code_injection.py                      @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/header_injection.py                    @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/insecure_cookie.py                     @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/sql_injection.py                       @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/weak_cipher.py                         @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/weak_hash.py                           @DataDog/asm-python
tests/appsec/iast/test_processor.py                                     @DataDog/asm-python
tests/appsec/iast/test_telemetry.py                                     @DataDog/asm-python

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited
Loading

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 234 ± 3 ms.

The average import time from base is: 236 ± 3 ms.

The import time difference between this PR and base is: -1.6 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.932 ms (0.82%)
ddtrace.bootstrap.sitecustomize 1.258 ms (0.54%)
ddtrace.bootstrap.preload 1.258 ms (0.54%)
ddtrace.internal.remoteconfig.client 0.626 ms (0.27%)
ddtrace 0.674 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-05-19 07:45:07

Comparing candidate commit cf84ff8 in PR branch avara1986/APPSEC-57161_new_iast_sampling_3 with baseline commit a3497e7 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 521 metrics, 5 unstable metrics.

scenario:iast_aspects-ospathsplitext_aspect

  • 🟥 execution_time [+697.420ns; +766.939ns] or [+15.456%; +16.997%]

scenario:iast_aspects-swapcase_aspect

  • 🟥 execution_time [+210.639ns; +252.347ns] or [+8.532%; +10.221%]

@avara1986 avara1986 marked this pull request as ready for review May 14, 2025 09:15
@avara1986 avara1986 requested a review from a team as a code owner May 14, 2025 09:15
christophe-papazian
christophe-papazian reviewed May 15, 2025
View reviewed changes
@avara1986 avara1986 merged commit 80ec4b6 into main May 19, 2025
441 of 442 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-57161_new_iast_sampling_3 branch May 19, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophe-papazian christophe-papazian christophe-papazian approved these changes

@RamyElkest RamyElkest Awaiting requested review from RamyElkest

Assignees
No one assigned
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avara1986 @christophe-papazian